[codegen] migrate stdlib/crypto to emitsymbol/emitoperand helpers#648
Merged
[codegen] migrate stdlib/crypto to emitsymbol/emitoperand helpers#648
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
stdlib/crypto.tsbuilt LLVM IR via rawctx.emit()template-literal strings, hardcoding@funcsymbols andi8* %tmpoperands throughout every hash/hmac/pbkdf2/uuid helper.After
No user-facing change. Internal refactor only. Symbol/operand formatting now flows through
emitSymbol(name, "@")andemitOperand(value, type)helpers at every call site. Rawctx.emit()is retained for the call/GEP/load/store/bitcast skeleton to preserve exact pre-migration IR (see Description).Description
Continues Step 2 of #640. Third wave after PR #645 (math/process) and PR #647 (console/date).
Scope matches Step 2's intent: only
emitSymbol/emitOperandhelpers. An initial version of this PR also migratedemitCall/emitCallVoid/emitGep/emitLoad/emitStore/emitBitcast(structured IR builders). Those broke stage2arrays/array-isarrayself-hosting on CI — crypto.ts is linked intosrc/chad-native.ts, so a miscompile of crypto codegen corrupts the stage1 compiler which then silently miscompiles unrelated fixtures. See #649. Structured-builder migration is deferred until the root cause in those helpers is investigated.Fixes #649.